On Mon, Jan 10, 2011 at 08:36:12PM +0000, Adam D. Barratt wrote: > On Sun, 2011-01-09 at 23:39 +0000, Roger Leigh wrote: > > On Sun, Jan 09, 2011 at 10:38:09PM +0000, Adam D. Barratt wrote: > > > On Fri, 2011-01-07 at 15:06 +0000, Roger Leigh wrote: > > > > We also update > > > > the 50chrootname setup script to handle non-UUID generated session > > > > names. > > > > > > That's presumably this addition: > > > > > > 's/-[0-9][0-9]*-[0-9][0-9]*//g' > [...] > > > Apologies if I'm missing something related to the context, but isn't > > > there a danger of that regex being insufficiently specific? > > > > No, you're right. The non-UUID session names we use for kfreebsd are > > made from the time (seconds since epoch) + PID to guarantee uniqueness. > > I could require more digits to make it specific. The PID should always > > be at least three digits and the time at least 10 digits, so I can add > > the extra [0-9] to the regex to do that. > > That would seem cleaner, although by the sound of it the practical > impact either way is minimal. I have made (and tested) this change, including accounting for PID wraparound. > schroot 1.4.17-1 has now migrated, so please feel free to upload 1.4.18 > (although preferably without much delay). Thanks, I have released, tested, built and uploaded. Regards, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linux http://people.debian.org/~rleigh/ `. `' Printing on GNU/Linux? http://gutenprint.sourceforge.net/ `- GPG Public Key: 0x25BFB848 Please GPG sign your mail.
Attachment:
signature.asc
Description: Digital signature