Re: Unblock xserver-xorg-video-geode
On Thu, Sep 23, 2010 at 9:06 PM, Julien Cristau <jcristau@debian.org> wrote:
> On Thu, Sep 23, 2010 at 17:05:46 +0300, Martin-Éric Racine wrote:
>
>> The updated package has been sitting in unstable for a couple of days
>> with no new issue reported. At this point, I really cannot think of
>> any remaining issue to address. Can we please get this unblocked now?
>>
> I don't see where you need xutils-dev.
The configure script complained about a missing file that according to
packages.d.o is provided by xutils-dev. Adding that Build-Depends
indeed made the message disappear.
> + /* Allocates shadow memory, and allocating a new space for Rotatation.
>
> it's spelled "rotation".
Where was this again? It's only a typo in the comment, but I could at
least fix it in GIT.
> + return MODE_BAD;
>
> it might be nice to return one of the more descriptive errors.
Sounds good to me too. Where exactly would you add it? Again, I could
fix it in GIT.
> 2.11.9-3 unblocked.
Thanks!
Martin-Éric
Reply to: