Re: Unblock xserver-xorg-video-geode
- To: "Huang, FrankR" <FrankR.Huang@amd.com>
- Cc: q-funk@iki.fi, Otavio Salvador <otavio@ossystems.com.br>, debian-release <debian-release@lists.debian.org>, "Cui, Hunk" <Hunk.Cui@amd.com>
- Subject: Re: Unblock xserver-xorg-video-geode
- From: Julien Cristau <jcristau@debian.org>
- Date: Fri, 3 Sep 2010 10:46:04 +0200
- Message-id: <[🔎] 20100903084604.GA10843@patate.is-a-geek.org>
- Mail-followup-to: Julien Cristau <jcristau@debian.org>, "Huang, FrankR" <FrankR.Huang@amd.com>, q-funk@iki.fi, Otavio Salvador <otavio@ossystems.com.br>, debian-release <debian-release@lists.debian.org>, "Cui, Hunk" <Hunk.Cui@amd.com>
- In-reply-to: <[🔎] DD1CC71B621B004FA76856E5129D6B170334DA2D@sbjgexmb1.amd.com>
- References: <AANLkTinifKg=2cnFjU7UzhCZ=YbNz+k25CF8f+SdQKop@mail.gmail.com> <20100827180043.GB10843@patate.is-a-geek.org> <AANLkTikJ74w0YK_krjayNcnGk-jkWNk7iDCqY-ndvvWH@mail.gmail.com> <AANLkTikxmnKENT+CtcBkQtgACoBknsM-4E_=Tn16E=Rg@mail.gmail.com> <20100831083237.GM10843@patate.is-a-geek.org> <AANLkTi=EPNtpWoQFroQgjLTM92cDqCBAe-+_10p82+uO@mail.gmail.com> <[🔎] DD1CC71B621B004FA76856E5129D6B170334DA2D@sbjgexmb1.amd.com>
On Fri, Sep 3, 2010 at 09:33:19 +0800, Huang, FrankR wrote:
> Otavio,
>
> I saw this thread from top to the end.
> Is it because the patch
> http://cgit.freedesktop.org/xorg/driver/xf86-video-geode/commit/?id=e9447f5335681a78cf87ebf8c9659a6fecfc9746
> block the geode driver to be accepted?
> If that is so, can we agree with the suggestion from Julien?
> if ((pGeode->Output & (OUTPUT_PANEL | OUTPUT_DCON)) ==
> (OUTPUT_PANEL | OUTPUT_DCON))
>
Well, or you could make it if (pGeode->Output == (OUTPUT_PANEL |
OUTPUT_DCON)). Or alternatively, explain why the existing code is
correct.
Another question is whether your EXA composite paths are reliable enough
now, or whether we'd better disable them for release.
Cheers,
Julien
Attachment:
signature.asc
Description: Digital signature
Reply to: