[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Fixing l10n issue with a translation update



On Wed, 2010-11-10 at 13:42 -0400, David Prévot wrote: 
> #592081 against debsums ships a non invasive patch to be fixed:
> 
> % diff -u /usr/bin/debsums /tmp/debsums
> - --- /usr/bin/debsums	2010-05-11 23:46:48.000000000 +0200
> +++ /tmp/debsums	2010-11-02 11:51:55.493098508 +0100
> @@ -216,7 +216,7 @@
>  }
> 
>  my %diversion;
> - -for (`/usr/sbin/dpkg-divert --list`)
> +for (`LC_MESSAGES=C /usr/sbin/dpkg-divert`)
>  {
>      my ($by) = /^(local) diversion/ ? $1 : / by (\S+)$/;
>      $diversion{$1} = [$2, $by]

That patch is broken (missing "--list" in the new version).  The version
in the bug log looks ok, though.

> If you agree to include this sort of patch, maybe fixing #602187 (which
> is beyond the borderline of the deep freeze), with the proposed patch
> that affects the very same line could also be done in the same time:

I debated this one a little, but the change looks sane enough.  Please
go ahead.

Regards,

Adam


Reply to: