[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Fixing l10n issue with a translation update



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

As advised by Julien Cristau on IRC, may I ask you if it is acceptable
to fix an easy l10n issue with a “translation update” upload.

#592081 against debsums ships a non invasive patch to be fixed:

% diff -u /usr/bin/debsums /tmp/debsums
- --- /usr/bin/debsums	2010-05-11 23:46:48.000000000 +0200
+++ /tmp/debsums	2010-11-02 11:51:55.493098508 +0100
@@ -216,7 +216,7 @@
 }

 my %diversion;
- -for (`/usr/sbin/dpkg-divert --list`)
+for (`LC_MESSAGES=C /usr/sbin/dpkg-divert`)
 {
     my ($by) = /^(local) diversion/ ? $1 : / by (\S+)$/;
     $diversion{$1} = [$2, $by]


If you agree to include this sort of patch, maybe fixing #602187 (which
is beyond the borderline of the deep freeze), with the proposed patch
that affects the very same line could also be done in the same time:

% diff -u /usr/bin/debsums /tmp/debsums
- --- /usr/bin/debsums	2010-05-11 23:46:48.000000000 +0200
+++ /tmp/debsums	2010-11-02 11:51:55.493098508 +0100
@@ -216,7 +216,7 @@
 }

 my %diversion;
- -for (`/usr/sbin/dpkg-divert --list`)
+for (`LC_MESSAGES=C /usr/sbin/dpkg-divert --list --admindir $admindir`)
 {
     my ($by) = /^(local) diversion/ ? $1 : / by (\S+)$/;
     $diversion{$1} = [$2, $by]


Please note that Ryan, the actual maintainer, already agreed for the
translation update and is fine with me fixing these tiny stuff if you agree:

Le 09/11/2010 21:07, Ryan Niebur a écrit :
> On Tue, Nov 09, 2010 at 08:34:12PM -0400, David Prévot wrote:
>>
>> #592081 seems to me like a l10n issue, and the proposed patch is really
>> not invasive. Do you want me to include it in the NMU I'm willing to
>> build tomorrow (and will reach the archive Tuesday, November 16, 2010)?
>>
>> Please note that #602187 proposed patch affects the same line, but may
>> be beyond the borderline of the RT.
> 
> I'm fine with you fixing either of these, however I'll leave the
> decision of what to include in this upload to you since I don't know
> what would be beyond the borderline.

Regards

David

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkza2ZwACgkQ18/WetbTC/qP+QCfdm+Dd167kSgt0MBU5YAGarXf
qmUAoI9gB0rFbkUJI0GpbF82n95Z5v4d
=eHCV
-----END PGP SIGNATURE-----


Reply to: