djvulibre exception request
I've uploaded djvulibre 3.5.23-1 and am hoping to have it allowed to
migrate into testing. Reason: the substantive changes from the
current version in testing are almost entirely bug fixes, including
two rather nasty ones.
One of these bugs (562156) causes incorrect PDF to be generated in
some locales. Another (582961) is a thread-related race condition
which causes mysterious silent crashes of the tools. A third (539272)
causes silent (exit condition 0) failure for tiny images. The first
two of these could easily be considered RC, as they are the sort of
thing that cause automated image processing toolchains and scripts to
silently give incorrect output. I am happy to raise their severity in
the BTS if the release team so desires.
Having looked through the changes in some detail, I do not think it is
worth trying to tease out just those changes related to the above
bugs: the other changes are either minor, or only active at build
time, or are to documentation. And trying to tease things apart could
result in breaking code, because the individual patches sometimes
contain straggler typo fixes and such. I think the odds of
accidentally introducing a problem that way exceed the odds of their
being a problem lurking in the very tiny number of substantive
non-critical changes.
A broken-down diffstat with comments appears below.
--Barak.
--
Barak A. Pearlmutter
Hamilton Institute & Dept Comp Sci, NUI Maynooth, Co. Kildare, Ireland
http://www.bcl.hamilton.ie/~barak/
----------------------------------------------------------------
diffstat of djvulibre from 3.5.22-9 to 3.5.23-2, broken down by
category, with summary of changes in each category.
Replicate, or examine diff in detail, with, eg:
git clone git://git.debian.org/git/collab-maint/djvulibre.git
cd djvulibre
git diff --stat debian/3.5.22-9..debian/3.5.23-2 -- NEWS *.spec tools/*.1
git diff debian/3.5.22-9..debian/3.5.23-2 -- */*.h */*.c */*.cpp
DETAILS
================================
Autotools refresh
(vast bulk of the diff; does not require examination.)
aclocal.m4 | 7 +-
config/acinclude.m4 | 16 +-
config/config.guess | 149 +-
config/config.h.in | 12 +-
config/config.sub | 47 +-
config/install-sh | 560 +-
config/libtool.m4 | 8728 ++++++++------
config/ltmain.sh | 8452 ++++++++------
config/ltoptions.m4 | 368 +
config/ltsugar.m4 | 123 +
config/ltversion.m4 | 23 +
config/lt~obsolete.m4 | 92 +
configure |30932 +++++++++++++++++-----------------------------
configure.ac | 97 +-
Subtotal: 14 files changed, 22311 insertions(+), 27295 deletions(-)
================================
Documentation
(does not require serious examination; the change to djvulibre.spec
is just the version number; most other documentation updates
correspond to code already present in 3.5.22-9.)
NEWS | 12 +-
djvulibre.spec | 2 +-
tools/cjb2.1 | 2 +-
tools/ddjvu.1 | 6 +
Subtotal: 4 files changed, 17 insertions(+), 5 deletions(-)
================================
Upstream build changes
(previously used "convert" aka imagemagick to generate bitmaps from
svg files; changed to try "rsvg" first, with fail-back to "convert".
This change was made in response to changes in the way imagemagick
was modularized, which increased its brittleness for this purpose.)
desktopfiles/Makefile.in | 7 +-
Subtotal: 1 files changed, 5 insertions(+), 2 deletions(-)
================================
Upstream code changes
(mainly bug fixes: thread race condition bug, tiny image bug,
locale-related PDF output bug, an ARM thumb port issue which is
#ifdef'ed out on other architectures, and some MS Windows fixes that
are #ifdef'ed in only on MS Windows.)
libdjvu/ddjvuapi.h | 1 +
libdjvu/GThreads.cpp | 10 +-
tools/bzz.cpp | 1 +
tools/c44.cpp | 1 +
tools/cjb2.cpp | 1 +
tools/cpaldjvu.cpp | 1 +
tools/csepdjvu.cpp | 1 +
tools/ddjvu.cpp | 50 +-
tools/djvm.cpp | 1 +
tools/djvmcvt.cpp | 1 +
tools/djvudump.cpp | 1 +
tools/djvuextract.cpp | 1 +
tools/djvumake.cpp | 1 +
tools/djvused.cpp | 10 +-
tools/djvuserve.cpp | 2 +-
tools/tiff2pdf.c | 11 +-
Subtotal: 16 files changed, 64 insertions(+), 30 deletions(-)
================================
Network script bug fix
(Fix small but annoying bash script bug.)
tools/any2djvu | 2 +-
Subtotal: 1 files changed, 1 insertions(+), 1 deletions(-)
================================
debian/
(Addition of --enable-djview during configuration to counteract
change in upstream default, build dependency on rsvg to take
advantage of upstream icon generation improvement, minor debian
packaging updates and upgrades, minor simplification of debian/rules,
accept Ubuntu debian/rules patch to use dh --with autotools_dev,
whitespace changes, update changelog. The line added to
config/.cvsignore is logically part of the --with autotools_dev.)
debian/README.Debian | 25 +-
debian/changelog | 23 +
debian/control | 17 +-
debian/rules | 56 +-
debian/source/format | 1 +
config/.cvsignore | 1 +
Subtotal: 6 files changed, 78 insertions(+), 45 deletions(-)
================================
Total
42 files changed, 22476 insertions(+), 27378 deletions(-)
================================================================
diffstat of everything *except* the autotools refresh.
$ git diff --stat debian/3.5.22-9..debian/3.5.23-2 -- [bd-z]* config/.cvsignore
NEWS | 12 +++++++--
config/.cvsignore | 1 +
debian/README.Debian | 25 ++++++++++++++++++--
debian/changelog | 23 +++++++++++++++++++
debian/control | 17 ++++++++++---
debian/rules | 56 ++++++++++++++-------------------------------
debian/source/format | 1 +
desktopfiles/Makefile.in | 7 ++++-
djvulibre.spec | 2 +-
libdjvu/GThreads.cpp | 10 ++++++-
libdjvu/ddjvuapi.h | 1 +
tools/any2djvu | 2 +-
tools/bzz.cpp | 1 +
tools/c44.cpp | 1 +
tools/cjb2.1 | 2 +-
tools/cjb2.cpp | 1 +
tools/cpaldjvu.cpp | 1 +
tools/csepdjvu.cpp | 1 +
tools/ddjvu.1 | 6 +++++
tools/ddjvu.cpp | 50 ++++++++++++++++++++++++----------------
tools/djvm.cpp | 1 +
tools/djvmcvt.cpp | 1 +
tools/djvudump.cpp | 1 +
tools/djvuextract.cpp | 1 +
tools/djvumake.cpp | 1 +
tools/djvused.cpp | 10 ++++++-
tools/djvuserve.cpp | 2 +-
tools/tiff2pdf.c | 11 +++++----
28 files changed, 165 insertions(+), 83 deletions(-)
Reply to: