On Sun, Aug 29, 2010 at 12:07:22PM +0200, Marc 'HE' Brockschmidt wrote: > Roger Leigh <rleigh@codelibre.net> writes: > > On Sat, Aug 28, 2010 at 01:33:10PM +0200, Marc 'HE' Brockschmidt wrote: > >> Roger Leigh <rleigh@codelibre.net> writes: > >>> Please could you unblock schroot 1.4.10-2? > >> 127 files changed, 6132 insertions(+), 6896 deletions(-) > >> > >> *cough* This is a bit much and far away from properly reviewable - even > >> if we filter out all autoconf crop and documentation updates. Are all of > >> these changes really needed? > > Yes. If you look at the diffstat (below), > > We always do that when reviewing changes. In this case, this ends up with > he@franck:~$ filterdiff -i *.cc -i *.h < schroot-diff | diffstat > [...] > 79 files changed, 1255 insertions(+), 726 deletions(-) > > As schroot is an important part of the Debian infrastructure, I'm even > more reluctant to just accept these changes into stable. How have these > changes been tested? I've done hand testing of all changes myself in addition to testing with the included testsuite. 1.4.8 contained the majority of the changes with all subsequent releases basically being additional bugfixes. Note that quite a lot of those fixes also affect 1.4.7 in testing as well; I don't consider 1.4.7 to be a better release than 1.4.11 (all subsequent changes were fixing known bugs and I spent the last two months doing nothing but working toward getting schroot in the best state possible for squeeze). Testing in unstable over the last few weeks has revealed a small number of regressions which have been fixed; there are no known issues in need of fixing at this point, and I'd strongly recommend having 1.4.11 in squeeze. I've also tested it with sbuild, and all the releases are all known to function correctly when run with sbuild. Releases later than 1.4.7 also deprecate features for removal in squeeze+1. If we don't have an update in squeeze, I'll need to postpone some changes until squeeze+2 which I would really prefer not to do. Regards, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linux http://people.debian.org/~rleigh/ `. `' Printing on GNU/Linux? http://gutenprint.sourceforge.net/ `- GPG Public Key: 0x25BFB848 Please GPG sign your mail.
Attachment:
signature.asc
Description: Digital signature