Roger Leigh <rleigh@codelibre.net> writes: > On Sat, Aug 28, 2010 at 01:33:10PM +0200, Marc 'HE' Brockschmidt wrote: >> Roger Leigh <rleigh@codelibre.net> writes: >>> Please could you unblock schroot 1.4.10-2? >> 127 files changed, 6132 insertions(+), 6896 deletions(-) >> >> *cough* This is a bit much and far away from properly reviewable - even >> if we filter out all autoconf crop and documentation updates. Are all of >> these changes really needed? > Yes. If you look at the diffstat (below), We always do that when reviewing changes. In this case, this ends up with he@franck:~$ filterdiff -i *.cc -i *.h < schroot-diff | diffstat [...] 79 files changed, 1255 insertions(+), 726 deletions(-) As schroot is an important part of the Debian infrastructure, I'm even more reluctant to just accept these changes into stable. How have these changes been tested? Marc -- BOFH #63: not properly grounded, please bury computer
Attachment:
pgpeR_ncokKj9.pgp
Description: PGP signature