Re: Please consider migrating gearman-interface 0.13.2-2 to testing

[Clint Byrum <clint@ubuntu.com>]

Hi Adam, thanks very much for taking a look!

On Aug 21, 2010, at 11:45 AM, Adam D. Barratt wrote:

> On Sat, 2010-08-21 at 09:17 -0700, Clint Byrum wrote:
>>   * debian/rules: moving tarball .c files out of the way so swig will
>>       rebuild and ship the .py files. (Closes: #593642)
> 
> So far as I can see, this:
> 
> [ -f python/libgearman.c.orig ] || [ -f python/libgearman.c ] && mv -f python/libgearman.c python/libgearman.c.orig || true
> 
> will attempt the mv if python/libgearman.c.orig exists but
> python/libgearman.c does not; was that intentional?
> 

Definitely not. The intention is to only do the move if libgearman.c.orig
does not exist, and libgearman.c does.

I suppose this actually does the same thing:

mv -n python/libgearman.c python/libgearman.c.orig || true

>>   * add description of gearman to long description (quiets lintian)
>>   * Removing unnecessary build depends on ruby/rubygems
>>   * Version build-dep on python3
>>   * change python:Provides to python3:Provides
>>   * re-enable dh_usrlocal
> 
> Why was the override added in the first place?
> 

Somehow this slipped through, it was overridden during a bit of frantic
iterative building/failing early in the package's life, and never 
re-enabled, but the override was never actually necessary.