[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Permission to upload new bugfix-only release of mozplugger (fixes important bug)

On Sat, August 7, 2010 11:43, Alessio Treglia wrote:
> On Sat, Aug 7, 2010 at 5:31 PM, Adam D. Barratt
> <adam@adam-barratt.org.uk> wrote:
>> How big is the diff for that?
> attaching the debdiff.


Part of the temporary file changes - specifically guessTmpFile() -
seems... strange.  I realise this is largely a refactoring of existing
code, but nevertheless it seems an odd solution.

So far as I can see, the code basically does:

* try to generate <tmpdir>/<filename>

* if that fails, try each of <tmpdir>/001-<filename> to

* if that fails, fall back to using mkstemp()

Is there a good reason that the code doesn't simply call mkstemp() in the
first place?



Reply to: