Quoting Christian Perrier (bubulle@debian.org): > >> Would it be OK to upload this to s-p-u? > > > > Yes, please upload. > > > I have another one..:-) > > In #520794, a memory leak was reported when users use the full_audit > VFS module along with Samba. > > It was corrected upstream in 3.2.8 with the attached patch. > > One of the users affected by the bug reported that the patch fixed the > problem for him. > > Would you mind if I upload to s-p-u with that fix in addition to the > fix #522907? Hmmm, having the patch may help.. --
Goal: fix memory leak in vfs_full_audit Fixes: #520794 Status wrt upstream: Fixed in 3.2.8 Author: Volker Lendecke <vl@samba.org> Index: lenny/source/modules/vfs_full_audit.c =================================================================== --- lenny.orig/source/modules/vfs_full_audit.c +++ lenny/source/modules/vfs_full_audit.c @@ -701,6 +701,7 @@ static char *audit_prefix(TALLOC_CTX *ctx, connection_struct *conn) { char *prefix = NULL; + char *result; prefix = talloc_strdup(ctx, lp_parm_const_string(SNUM(conn), "full_audit", @@ -708,12 +709,14 @@ if (!prefix) { return NULL; } - return talloc_sub_advanced(ctx, + result = talloc_sub_advanced(ctx, lp_servicename(SNUM(conn)), conn->user, conn->connectpath, conn->gid, get_current_username(), current_user_info.domain, prefix); + TALLOC_FREE(prefix); + return result; } static bool log_success(vfs_handle_struct *handle, vfs_op_type op)
Attachment:
signature.asc
Description: Digital signature