Hello guys, Bug #522907 seems to affect users who use Winbind along with an OpenLDAP server. These users are experiencing frequent winbind crashes that seem to de due to a behaviour of OpenLDAP that hadn't been anticipated by Samba developers. Upstream Samba developers made a (simple) patch to fix this, which will be pushed in their 3.3.4 and 3.2.12 releases (FYI, we have 3.2.5 in lenny). It might be possible that #484235 is also fixed by this patch. The planned patch is attached. Would it be OK to upload this to s-p-u? --
Goal: Fix winbind crashes when interacting with OpenLDAP by having
ldap_search_with_timeout() always returns LDAP_TIMELIMIT_EXCEEDED
in the error case
Fixes: #522907
Status wrt upstream: Fixed in 3.3.4
Author: Jeremy Allison <jra@samba.org>
Index: samba-3.2.5/source/libads/ldap.c
===================================================================
--- samba-3.2.5.orig/source/libads/ldap.c
+++ samba-3.2.5/source/libads/ldap.c
@@ -118,6 +118,10 @@
if (gotalarm != 0)
return LDAP_TIMELIMIT_EXCEEDED;
+ if (*res == NULL) {
+ return LDAP_TIMELIMIT_EXCEEDED;
+ }
+
return result;
}
Attachment:
signature.asc
Description: Digital signature