[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: JD package for Lenny point release



On Wed, Apr 01, 2009 at 05:20:38PM +0100, Holger Levsen wrote:
> Hi,
> 
> On Mittwoch, 1. April 2009, Hideki Yamane wrote:
> >  Until change happened in BBS, hardcoded cookie "hana=mogera" was used.
> >  After the change, JD needs to add functions and fixes for that cookie
> >  code, so it's big but is needed (to make it from "half-broken" to fixed
> > one).
> > http://mentors.debian.net/debian/pool/main/j/jd/jd_2.0.0-080722-2+lenny1.dsc
> 
> $ debdiff jd_2.0.0-080722-2.dsc jd_2.0.0-080722-2+lenny1.dsc|diffstat
>  debian/patches/post-cookie.dpatch     | 2696 ++++++++++++++++++++++++++++++++++
>  jd-2.0.0-080722/debian/changelog      |    7 
>  jd-2.0.0-080722/debian/control        |    2 
>  jd-2.0.0-080722/debian/patches/00list |    1 
>  4 files changed, 2705 insertions(+), 1 deletion(-)
> 
> SRMs, would that be ok for 5.0.2? If not, I'd suggest removal from stable.

The diffstat is a bit off because the dpatch is very unclean.  Here's the
diffstat for the dpatch:

pkern@asterix:/tmp/jd-2.0.0-080722/debian/patches$ diffstat post-cookie.dpatch 
 board/preference.cpp      |   18 
 board/preference.cpp.orig |  404 +++++++++++++++++
 board/preference.h        |    2 
 dbtree/article2ch.cpp     |    6 
 dbtree/board2ch.cpp       |   67 ++
 dbtree/board2ch.h         |    4 
 dbtree/boardbase.h        |   16 
 dbtree/boardbase.h.orig   |  444 +++++++++++++++++++
 dbtree/interface.cpp      |   14 
 dbtree/interface.cpp.orig | 1057 ++++++++++++++++++++++++++++++++++++++++++++++
 dbtree/interface.h        |    5 
 message/post.cpp          |   46 --
 message/post.cpp.orig     |  396 +++++++++++++++++
 message/post.h            |    3 
 14 files changed, 2426 insertions(+), 56 deletions(-)

As you see many complete origs in there.

I am, however, unable to review the remainder as the source comments are in
Japanese.  I think considering the much fewer size than we originally assumed
that this could be safe for stable inclusion.  So please go ahead and get it
into p-u-NEW.  (Pretty please, with a clean dpatch.)

Kind regards,
Philipp Kern
-- 
 .''`.  Philipp Kern                        Debian Developer
: :' :  http://philkern.de                         Stable Release Manager
`. `'   xmpp:phil@0x539.de                         Wanna-Build Admin
  `-    finger pkern/key@db.debian.org

Attachment: signature.asc
Description: Digital signature


Reply to: