[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: pre-approval for openoffice.org 1:2.4.1-16 upload seeked (was: Re: Bug#507865: openoffice.org-writer: OOo 2.4.x openinig OOo 3) files doesn't show text (2.x implements standard wrong)

* Rene Engelhard [Wed, 14 Jan 2009 14:48:01 +0100]:

> Hi -release,


> Besides the fix for #507865, which now has a proposed patch[1],
> [1] http://www.openoffice.org/issues/show_bug.cgi?id=96878#desc17

Great. Do we need to wait for the review mentioned in #desc19?

> I'd like to
> include a few more (mainly uncontroversial, except one..) fixes (all backported
> from the 3.0.x packages):

> - report-builder needs Java but does not depend on it
> - base-core missed a dep on openoffice.org-core

> - README/LICENSE files (cosmetical, I agree, but...)
> - add some pointer to upstreams README for "Problems During Program Startup"
>   and "File Locking" in presubj.

All ok.

> Also some lintian fixes:

It's not really the time to clean up lintian if it's just cosmetic...
I'll comment on it, but if people refrain from requesting it, it's less
time wasted for everybody.

> +  * debian/shell-lib.sh: remove long obsolete "trap {...}". bashism anyway.
> +    Thanks lintian.

I don't think it's a bashism. At least, dash seems to take it just fine.
Include it if you must.

> +  * debian/source.lintian-overrides: override bogus
> +    missing-build-dependency-for-dh_-command

You should explain, to me and in the changelog, why is it bogus. I
couldn't figure it out, and that's what changelogs are for.

> And last but not least (and that might be the controversial part):

> - disable -gcj for ppc, as gij does not work on ppc anyway (#478760) and
>   thus is just cruft.

So, I assume that even with disabling this, powerpc users can still use
the functionality with OpenJDK?

If a package is broken in an architecture, an alternative implementation
exists, and all users are going to get by its presence is pain for
seeing it not work, then I see nothing controversial about the removal.
Unless I've missed something.


Adeodato Simó                                     dato at net.com.org.es
Debian Developer                                  adeodato at debian.org
                           Listening to: Rosa León - Con un poco de amor

Reply to: