[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: approval for planned upload of ippan 4.86a-7



(Apache2 maintainers, CC'ed, context is #511293.)

* Jan Wagner [Tue, 13 Jan 2009 13:20:04 +0100]:

> -		    elif [ -f /usr/lib/apache/1.3/libphp3.so ]; then
> -			if ! grep -qs "^LoadModule php3_module " /etc/$webserver/modules.conf; then
> -			    modules-config $webserver enable mod_php3
> +		    elif [ -f /usr/lib/apache/1.3/libphp5.so ]; then
> +			if ! grep -qs "^LoadModule php5_module " /etc/$webserver/modules.conf; then
> +			    modules-config $webserver enable mod_php5

Ok.

>  		    if [ -f /etc/apache2/mods-available/php4.load ]; then
> -			if [ ! -f /etc/$webserver/mods-enabled/php4.load -a ! -h /etc/$webserver/mods-enabled/php4.load ]; then
> +			if [ ! -f /etc/$webserver/mods-enabled/php4.load -a ! -h /etc/$webserver/mods-enabled/php4.load -a -f /usr/lib/$webserver/modules/libphp4.so ]; then
>  			    ln -s /etc/$webserver/mods-available/php4.load /etc/$webserver/mods-enabled/php4.load
>  			fi

How about:

  if [ -f /usr/lib/$webserver/modules/libphp4.so ]; then
      a2enmod php4
  fi

and

>  		    elif [ -f /etc/apache2/mods-available/php5.load ]; then
> -			if [ ! -f /etc/$webserver/mods-enabled/php5.load -a ! -h /etc/$webserver/mods-enabled/php5.load ]; then
> +			if [ ! -f /etc/$webserver/mods-enabled/php5.load -a ! -h /etc/$webserver/mods-enabled/php5.load -a -f /usr/lib/$webserver/modules/libphp5.so ]; then
>  			    ln -s /etc/$webserver/mods-available/php5.load /etc/$webserver/mods-enabled/php5.load
>  			fi

  elif [ -f /usr/lib/$webserver/modules/libphp5.so ]; then
      a2enmod php5
  fi

?

Though if this is indeed the intended way to use it, let's see if the
apache2 maintainers have any comments.

If you prefer not to use a2enmod, please make the outer "if" and "elif"
test for the files in /usr/lib, instead of first mods-available, and
then, inside, /usr/lib/.../*.so.

> Index: debian/ipplan/trunk/debian/apache.conf
> ===================================================================
> --- debian/ipplan/trunk/debian/apache.conf (revision 1276)
> +++ debian/ipplan/trunk/debian/apache.conf (revision 1646)
> @@ -1,4 +1,4 @@
> +#Alias /ipplan/menus /usr/share/php/libphp-phplayersmenu
>  #Alias /ipplan /usr/share/ipplan
> -#Alias /ipplan/menus /usr/share/php/libphp-phplayersmenu

Ok.

-- 
Adeodato Simó                                     dato at net.com.org.es
Debian Developer                                  adeodato at debian.org
 
Don't be irreplaceable, if you can't be replaced, you can't be promoted.


Reply to: