Re: Adding D-Link DNS-323 support in a stable update of lenny
Matthew Palmer wrote:
> On Tue, Nov 11, 2008 at 06:01:07PM +0100, Luk Claes wrote:
>> Martin Michlmayr wrote:
>>> Matthew Palmer has recently created patches that add support for the
>>> If so, it would be nice to hint dns323-firmware-tools into lenny
>>> because we'll need this package to generate installer images for the
>>> DNS-323.
>> The manpage has '-c' for model on one place and '-m' in another place, I
>> guess it's a copy/paste error?
>
> Whups. As you suggest, that's a copy-paste error.
>
>> The executable uses /tmp/ctl_header which is a risk for a symlink attack
>> AFAIK.
>
> Heh, it's even worse than that -- it's debugging output I didn't properly
> notate and clean before I made ready for the release. Fixed.
I already wondered if it was strange ruby syntax or if the file was not
used anymore after that call :-)
>> It might be good to fix these two issues, then I won't have any
>> objection with including it in lenny.
>
> I'll upload a new version as soon as I've got 'net access again in an hour
> or so.
unblocked
Cheers
Luk
Reply to: