Hello, since the German translation for goobox contained an error, I corrected it (and pushed it upstream). Subsequently, I uploaded a new debian version (2.0.0-3) which has been built by most architectures already. The full changelog: goobox (2.0.0-3) unstable; urgency=low * L10n upload targetting Lenny * Update Arabic translation from upstream SVN * Update Czech translation from upstream SVN * Update German translation from upstream SVN * Update Brazilian translation from upstream SVN -- Helge Kreutzmann <debian@helgefjell.de> Sun, 17 Aug 2008 09:57:04 +0200 This is a pure l10n upload an hence should be acceptable for an unfreeze. Unfortunately, just after uploading two bugs have been reported[1], which both are easy and non-intrusive to fix: #495492: Previous upstream versions were able to create mp3 if the necessary package (not in Debian) was present, this is no longer the case. The fix is simple: remove README.Debian and Recommends to gstreamer-lame. Since Lenny users might search for mp3 encoding removing this information might save them some time. This fix does not alter the built binary in any way. #495491: A certain sequence with the preference dialog makes goobox crash (I confirmed this on ppc). The patch has been accepted (slightly updated) by upstream and is attached to this e-mail. While having this fix in Lenny would be nice (and the fix does not alter much), I understand that it might not be acceptable. I confirmed that the fix builds and works on ppc, before upload I would check for building on x86 as well. Would the RMs accept an upload of -4 including the fix for #495492 (and, if possible, for #495491 as well) targetting Lenny? If this is not possible I request a freeze exception for -3. If you need more information do not hesitate to ask. Greetings Helge [1] These were the first bugs for almost the entire development cycle for Lenny -- Dr. Helge Kreutzmann debian@helgefjell.de Dipl.-Phys. http://www.helgefjell.de/debian.php 64bit GNU powered gpg signed mail preferred Help keep free software "libre": http://www.ffii.de/
# Fix crash in properties dialog for wav files, taken from upstream SVN # Closes: #495491 Index: goobox-2.0.0-3test/src/dlg-preferences.c =================================================================== --- goobox-2.0.0-3test.orig/src/dlg-preferences.c 2008-08-18 19:22:46.000000000 +0200 +++ goobox-2.0.0-3test/src/dlg-preferences.c 2008-08-18 19:26:35.000000000 +0200 @@ -367,7 +367,7 @@ } gtk_combo_box_set_active (GTK_COMBO_BOX (data->p_filetype_combobox), file_format); - gtk_notebook_set_current_page (GTK_NOTEBOOK (data->p_encoding_notebook), file_format); + filetype_combobox_changed_cb (NULL, data); /**/ @@ -583,7 +583,7 @@ text = g_strdup_printf ("<big><b>%s</b></big>", _("FLAC")); break; default: - text = ""; + text = g_strdup (""); break; } gtk_label_set_markup (GTK_LABEL (f_title_label), text); @@ -597,6 +597,7 @@ text = _("Compression level:"); break; default: + text = ""; break; } gtk_label_set_text (GTK_LABEL (data->f_quality_label), text); @@ -612,6 +613,7 @@ text = _("WAV+PCM is a lossless format that holds uncompressed, raw pulse-code modulated (PCM) audio."); break; default: + text = ""; break; } gtk_label_set_text (GTK_LABEL (f_description_label), text); Index: goobox-2.0.0-3test/src/dlg-ripper.c =================================================================== --- goobox-2.0.0-3test.orig/src/dlg-ripper.c 2008-08-18 19:24:21.000000000 +0200 +++ goobox-2.0.0-3test/src/dlg-ripper.c 2008-08-18 19:26:35.000000000 +0200 @@ -401,7 +401,7 @@ char *url = NULL; scheme = gnome_vfs_get_uri_scheme (folder); - if ((scheme == NULL) || (scheme == "")) + if ((scheme == NULL) || (strcmp (scheme, "") == 0)) url = gnome_vfs_get_uri_from_local_path (folder); else url = g_strdup (folder);
Attachment:
signature.asc
Description: Digital signature