[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: New grub suitable for Etch



Hi,

Otavio Salvador <otavio@debian.org> writes:
> @@ -139,17 +143,16 @@
>  +      {
>  +       int f_len = grub_strlen(buf) - grub_strlen(tmp);
>  +       char *def;
> -+       int a;
> -+       for(a = 0; a < f_len; a++)
> -+         grub_memcpy(&def[a], &buf[a], sizeof(char));
> ++       buf[f_len] = '\0';
> ++       def = buf;
>  +       safe_parse_maxint (&def, &entryno);
>  +      }

I'm a bit confused by this part of the diff. I don't know what
grub_memcpy does exactly, but I guess it's roughly doing what memcpy
does. In that case, the new version is a significant change, are you
sure there are no side-effects?

Marc
-- 
Fachbegriffe der Informatik - Einfach erklärt
27: Durch das Volk übertragene gesellschaftliche Verantwortung in Bezug auf die
    zukünftige Gestaltung der Informationsgesellschaft wahrnehmen ...
       Das Internet zensieren ... (nach Peter Berlich)

Attachment: pgpS3C9qWQ3fl.pgp
Description: PGP signature


Reply to: