Re: New grub suitable for Etch
Marc 'HE' Brockschmidt <he@ftwca.de> writes:
> Hi,
>
> Otavio Salvador <otavio@debian.org> writes:
>> @@ -139,17 +143,16 @@
>> + {
>> + int f_len = grub_strlen(buf) - grub_strlen(tmp);
>> + char *def;
>> -+ int a;
>> -+ for(a = 0; a < f_len; a++)
>> -+ grub_memcpy(&def[a], &buf[a], sizeof(char));
>> ++ buf[f_len] = '\0';
>> ++ def = buf;
>> + safe_parse_maxint (&def, &entryno);
>> + }
>
> I'm a bit confused by this part of the diff. I don't know what
> grub_memcpy does exactly, but I guess it's roughly doing what memcpy
> does. In that case, the new version is a significant change, are you
> sure there are no side-effects?
Leandro was the guy who ported this code to 0.97 and is the most
experienced one on this part of code. I've added him on Cc and hope he
comments on it.
I wasn't the person who did this change. Leandro, can you comment on
this change?
--
O T A V I O S A L V A D O R
---------------------------------------------
E-mail: otavio@debian.org UIN: 5906116
GNU/Linux User: 239058 GPG ID: 49A5F855
Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
you the whole house."
Reply to: