[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: libnss-mdns



On Mon, May 30, 2005 at 11:03:28PM +1000, Anand Kumria wrote:
> I'm presently on the road (currently at GUADEC) and haven't been able to
> get Net access for a while.  However libnss-mdns which is currently in
> sarge (0.3) does not work on big-endian architectures.

> The 0.4 version available in unstable does (well no bug reports at
> least) and has minimal changes. I would appreciate it if you could
> upgrade the version in sarge to 0.4 prior to release.

This doesn't look very minimal at all to me; AFAICT, only one line of this
diff is related to the portability question:

@@ -248,7 +252,7 @@
             
             for (cmsg = CMSG_FIRSTHDR(&msg); cmsg != NULL; cmsg = CMSG_NXTHDR(&msg,cmsg)) {
                 if (cmsg->cmsg_level == SOL_IP && cmsg->cmsg_type == IP_TTL) {
-                    *ret_ttl = *(uint8_t *) CMSG_DATA(cmsg);
+                    *ret_ttl = (uint8_t) ntohl(*(uint32_t*)CMSG_DATA(cmsg));
                     break;
                 }
             }

If this is really the only bit needed, can this be backported via t-p-u,
please?

-- 
Steve Langasek
postmodern programmer



Reply to: