[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: evolution 2.0.4-2



Takuo KITAME wrote:
> 2005-05-08 (日) の 13:24 -0400 に Joey Hess さんは書きました:
> > I reviewed evolution 2.0.4-2 in t-p-u since it fixes a security hole, as
> > well as an important bug (#280303), but I'm not comfortable with all the
> > other changes in this patch:
> > 
> > - Several apparently minor translation changes, which I am not qualified
> >   to review, and which are not mentioned in the changelog and seem
> >   unrelated to the other changes.
> 
> they are auto generated files, maybe made by uncleanly build process. I
> I think, it should be removed from diff.

Aha.

> > - config.sub and config.guess updates look safe enough, but why are these
> >   necessary in a security release?
> 
> also made by uncleanly build process, should be removed.
> 
> > If you can explain these changes, I'll accept it. In the future limiting
> > security-fixing uploads to only fixing security holes is the best way to
> > get security holes fixed quickly.
> 
> Should I fix this diffs and upload 2.0.4-3?

No need, approved as is, thanks for the explanation.

-- 
see shy jo

Attachment: signature.asc
Description: Digital signature


Reply to: