On Mon, Mar 14, 2005 at 12:29:31PM +1100, Anibal Monsalve Salazar wrote:
> Please consider pidentd and portmap for sarge. They have been in sid
> for 33 and 36 days, respectively.
> pidentd (3.0.18-2) unstable; urgency=low
> .
> * Ported previuos patches to new upstream version.
> Fixed "Config file didn't specify a suitable path for pid file" (Closes: #291180).
> Fixed "New version is DoS-able and doesn't work well on load" (Closes: #291636).
> Patches by Toni Timonen <ttimonen@users.sourceforge.net>
> * New maintainer's email address.
> pidentd (3.0.18-1) unstable; urgency=low
> .
> * New upstream release.
> * Removed doc/rfc1413.txt.
pidentd approved, already in testing.
> portmap (5-8) unstable; urgency=low
> .
> * Fixed "discards port mappings on stop; start" (Closes: #293743).
> * Compilation warnings cleanup (Closes: #266481).
> Patch by Mark Ferlatte <ferlatte@cryptio.net>
> * Option to chroot portmap (Closes: #274178).
> Patch by Mark Ferlatte <ferlatte@cryptio.net>
> * New maintainer's email address.
@@ -162,16 +163,19 @@
struct sockaddr_in addr;
int len = sizeof(struct sockaddr_in);
register struct pmaplist *pml;
+ char *chroot_path = NULL;
struct in_addr bindaddr;
int have_bindaddr = 0;
- while ((c = getopt(argc, argv, "dvi:")) != EOF) {
+ while ((c = getopt(argc, argv, "dtvi:")) != EOF) {
switch (c) {
case 'd':
debugging = 1;
break;
-
+ case 't':
+ chroot_path = optarg;
+ break;
case 'v':
verboselog = 1;
break;
Has this actually been tested? It looks to me like 'optarg' will not be set
here because 't' has not been specified as an option that takes an argument.
For that, the call should be:
while ((c = getopt(argc, argv, "dt:vi:")) != EOF) {
If you can address that, I don't see any other problems with approving this
update.
Thanks,
--
Steve Langasek
postmodern programmer
Attachment:
signature.asc
Description: Digital signature