[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFC] fixing sourceforge watch files



* "Adam D. Barratt" <adam@adam-barratt.org.uk> (Tue, 17 Jun 2008 19:11:21 +0100):

> --- scripts/uscan.1	(revision 1502)
> +++ scripts/uscan.1	(working copy)

> -# If your package is located on sourceforge, use one of the following
> -# formats to automatically use the qa.debian.org redirector, avoiding
> -# SF's difficult mirror system.
> -http://sf.net/audacity/audacity-src-(.+)\\.tar\\.gz
> +# If your package is located on sourceforge, you can avoid its
> +# mirror system by using the following format. Note that the trailing
> +# \?.+ is required.
> +http://sourceforge.net/projects/audacity/files \\ 
> +  http://downloads.sourceforge.net/.+/audacity-src-(.+)\\.tar\\.gz\\?.+

Wouldn't it be better to end the match in "\.tar\.gz.*" instead of (an
explicit \? and) '.+'? That way, watch files wouldn't break should SF
choose to drop the query strings entirely. Avoiding the mirror_picker.php
URLs should already be provided by anchoring the match at
http://downloads.sourceforge.net/

Also keeping the "avoid its mirror system" phrase in the comment seems
misleading without the qa.debian.org redirector reference. AIUI, SF's
mirror system will still be used, just a mirror picked automatically
without the intermediary page. Plus, this seems to be the default now,
not a tricky circumvention.

And perhaps the fact that sf.net URLs were special-cased and
automatically rewritten by uscan in the past should stay mentioned even
if the feature should be removed, to help interpreting old watch files.

Regards, Fabian

P.S.: IANADD, and: Just my 2ct :)

-- 
Fabian "zzz" Pietsch - http://www.canvon.de/


Reply to: