On Tue, 05 Sep 2006, Kapil Hari Paranjape wrote: > I wonder ... policy says that clean must---*undo* the changes made by > 'build' and 'binary'---(my emphasis). > > So removing all the generated files may not be acceptable if > different versions of these had been packaged by upstream. This was in the context of #385980 (grub not cleaning its files). I am wrong about this. As the enclosed mail shows "clean" is allowed to remove all autogenerated files including the ones that came with the upstream source. Sorry for the misdirection. Thanks and regards, Kapil. -- On Thu, 21 Sep 2006, Joey Hess wrote: > Kapil Hari Paranjape wrote: > > Removal of the autogenerated files *is* what the "clean" target > > already does. The problem is that upstream source comes with its own > > set of autogenerated files and these get removed/replaced during the > > autoconf run. > > That doesn't make any sense. If the files are removed by the clean > target, they will not appear in the diff; this bug report shows them in > the diff. > > > I read that and have since then been going through my own packages > > trying to implement it. Since upstream is often not careful enough > > about "distclean", this requirement is sometimes rather hard to > > implement. > > To the contrary, it's trivial, you just remove them in the clean rule. > > dbs is a complete red herring in this discussion. > > Here's a patch to grub that fixes this bug: > > diff -ur old/grub-0.97/debian/rules grub-0.97/debian/rules > --- old/grub-0.97/debian/rules 2006-09-21 22:36:30.000000000 -0400 > +++ grub-0.97/debian/rules 2006-09-21 22:36:17.000000000 -0400 > @@ -181,7 +181,7 @@ > -( cd docs && rm -rf grub multiboot ) > > # remove files that will be change due our automake and autoconf rebuilding > - -rm -f $(find . -name 'Makefile.in' -o \ > + -rm -f $(shell find . -name 'Makefile.in' -o \ > -name 'aclocal.m4' -o \ > -name 'configure')
Attachment:
signature.asc
Description: Digital signature