Bug#886416: libnih: uninstallable, and FTBFS when rebuilt: FAIL test_parse (unexpected line numbering)
Control: tag -1 + pending
Hi Simon,
Simon McVittie wrote:
> > > - TEST_FILE_EQ (output, ("test:foo:2:0: "
> > > + TEST_FILE_EQ (output, ("test:foo:1:36: "
> > > "Invalid object path in <node> name attribute\n"));
[…]
> It certainly seems more true to say that the error in
> "<node name=\"com/netsplit/Nih/Test\"/>\n" is at line 1 column 36 (the
> closing double quote around the invalid object path) than at line 2
> column 0 (after the newline).
Argh! Thanks for enlightening me what these numbers mean!
Yes, indeed, that looks much more sane now. Might be related to this
bug fix in expat 2.2.5:
#137 #138 Fix a case of mistakenly reported parsing success where
XML_StopParser was called from an element handler
> > I'd appreciate some more eyes on that change as I have not much of an
> > idea of libnih's guts.
>
> I have no idea about how libnih works, but the change looks harmless at
> worst - it's not as if it changes the behaviour of non-test code, and the
> new output looks more correct than the old.
Thanks for the review! Will prepare an upload.
> (My only interest in libnih is in keeping libpam-systemd installable
> on buildds.)
(My only interest in libnih is in being able to continue to not have to
use systemd as init system on my systems without having to uninstall
about 500 packages. :-P)
Regards, Axel
--
,''`. | Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
Reply to: