Bug#886416: libnih: uninstallable, and FTBFS when rebuilt: FAIL test_parse (unexpected line numbering)

[Axel Beckert <abe@debian.org>]

Control: tag -1 + patch

Hi again,

Axel Beckert wrote:
> I don't know if that test suite failure shows that expat broke libnih
> or if the test suite just needs to be adapted to the new expat
> version.
> 
> Iff the later is the case, the following patch fixes the FTBFS:
> 
> --- a/nih-dbus-tool/tests/test_parse.c
> +++ b/nih-dbus-tool/tests/test_parse.c
> @@ -7950,7 +7950,7 @@
>  
>                 TEST_EQ_P (node, NULL);
>  
> -               TEST_FILE_EQ (output, ("test:foo:2:0: "
> +               TEST_FILE_EQ (output, ("test:foo:1:36: "
>                                        "Invalid object path in <node> name attribute\n"));
>                 TEST_FILE_END (output);
>                 TEST_FILE_RESET (output);
> 
> Haven't yet tried if the resulting packages still work, but will try
> that now.

So far no issues and nih-dbus-tool still generates a lot of C code.

The patch fixes the FTBFS with both, glibc 2.25 as well as glibc 2.26.

I've now pushed the above patch with some proper metadata to the newly
created git branch "adapt-testsuite-to-expat-2.2.5":

https://anonscm.debian.org/cgit/collab-maint/libnih.git/log/?h=adapt-testsuite-to-expat-2.2.5

I'd appreciate some more eyes on that change as I have not much of an
idea of libnih's guts.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE