Bug#874133: xfrisk: Always crashes due to "stack smashing" on pressing "Start game"
Hi again,
Axel Beckert wrote:
> > I'm not seeing any -O2 in the 1.2-3 build log,
> > so my next guess would be buggy code breaking
> > when compiled with optimization.
>
> Hrm, the old debian/rules contained this:
>
> CFLAGS = -Wall -g
> ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
> CFLAGS += -O0
> else
> CFLAGS += -O2
> endif
> export CFLAGS
>
> … so I thought that optimization shouldn't make a difference.
>
> But since the old package didn't pass through CFLAGS properly anyway
> (had to fix that in 1.2-4), that's indeed a good point. Will check,
> thanks!
Indeed, this line in debian/rules helps:
export DEB_CFLAGS_MAINT_APPEND=-O0
*sigh*
Thanks for the help!
Regards, Axel
--
,''`. | Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
Reply to: