[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#874133: xfrisk: Always crashes due to "stack smashing" on pressing "Start game"



Hi again,

Axel Beckert wrote:
> Adrian Bunk wrote:
> > Crashes for me with 1.2-4
> > Works for me with 1.2-3+b2
> > 
> > Looking at the build logs, the hardening flags
> > (especially -fstack-protector-strong) are new
> > in -4 and likely trigger the issue.
> 
> Thanks for that hint! Didn't notice it when uploading 1.2-4. Probably
> didn't test far enough.

Hrm, The crashes are less verbose with "export
DEB_BUILD_MAINT_OPTIONS=hardening=-all", "export
DEB_BUILD_MAINT_OPTIONS=hardening=-stackprotectorstrong" or "export
DEB_BUILD_MAINT_OPTIONS=hardening=-stackprotector,-relro,-pie", but
still there:

~ → xfrisk localhost
CLIENT: Connected to server.
CLIENT: Waiting for server to send client ID...Done.
[1]    11208 segmentation fault (core dumped)  xfrisk localhost

The backtrace now looks as follows:

(gdb) bt
#0  CBK_IncomingMessage (iMessType=<optimized out>, pvMess=0x555500000000) at callbacks.c:327
#1  0x000055555555cfc6 in CBK_XIncomingMessage (pClientData=<optimized out>, iSource=<optimized out>, 
    id=<optimized out>) at callbacks.c:97
#2  0x00007ffff72fc58a in XtAppProcessEvent () from /usr/lib/x86_64-linux-gnu/libXt.so.6
#3  0x00007ffff72f0dcd in XtAppMainLoop () from /usr/lib/x86_64-linux-gnu/libXt.so.6
#4  0x000055555555a28d in main (argc=2, argv=0x7fffffffdf38) at clientMain.c:103

Nevertheless it must be something which is part of the 1.2-4 packaging
as just recompiling xfrisk 1.2-3 under the same current environment
results in a working binary.

Will continue to dig deeper. Hints welcome, though.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE


Reply to: