Bug#874133: xfrisk: Always crashes due to "stack smashing" on pressing "Start game"

[Adrian Bunk <bunk@debian.org>]

On Sun, Sep 03, 2017 at 07:11:23PM +0200, Axel Beckert wrote:
> Hi,
> 
> Axel Beckert wrote:
> > Package: xfrisk
> > Version: 1.2-4
> > Severity: grave
> > 
> > xfrisk (initially started via "risk") always crashes as follows for me
> > if I click the "Start game" button or if I later call "xfrisk localhost"
> > with the server already running.
> 
> Since upstream has a release candidate of a future release available,
> I imported that one into the packaging and pushed the according
> package changes to a git branch named "experimental", see
> https://anonscm.debian.org/cgit/collab-maint/xfrisk.git/log/?h=experimental
> 
> Unfortunately that release candidate didn't fix this issue, so we very
> likely need to find the cause for this crash and make up a patch to
> fix it.

Crashes for me with 1.2-4
Works for me with 1.2-3+b2

Looking at the build logs, the hardening flags
(especially -fstack-protector-strong) are new
in -4 and likely trigger the issue.

> 		Regards, Axel

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed