Re: RFS: mwic 0.7.4-1
On Sat, Mar 17, 2018 at 5:49 PM, Georg Faerber wrote:
> Thanks a lot; sure, see [1].
These things block the upload:
The copyright years are missing 2012, I'm not sure if the ftp-masters
would reject the package on that basis.
I require these things to be fixed before I would sponsor the package:
doc/mwic.1 and tests/coverage are generated files, they should be
removed from the upstream VCS and tarballs and be always built from
source. If upstream refuses, you should remove them in `debian/rules
clean` and very early in `debian/rules build` so that the package will
never depend on the existing upstream files.
Some things that you may want to improve at some point:
Please include the upstream signature in the source package. uscan
does the right thing these days, or you can rename it to
mwic_0.7.4.orig.tar.gz.asc and place it alongside the orig.tar.gz file
and rebuild the source package.
I like to wrap each of the fields in debian/watch on new lines.
I like to use these wrap-and-sort parameters:
wrap-and-sort --short-indent --wrap-always --sort-binary-packages
--trailing-comma
misc/mwic4po seems like it would be worth installing in the package?
Please add some upstream metadata:
https://wiki.debian.org/UpstreamMetadata
Output from automated checks is available at the very end of this email.
> Could you move the repo as well, or create a new one within the Python
> team?
I'll leave that to someone who knows how to do that, I haven't dealt
with salsa yet.
> Yeah, I've used this as well, but in this case it's not that helpful as
> it finds the code defining the error [2].
I'd guess this is the source of the line you quoted:
https://sources.debian.org/src/autopkgtest/5.1/runner/autopkgtest/?hl=144#L138
lintian
X: mwic source: upstream-metadata-file-is-missing
check-all-the-things
$ env PERL5OPT=-m-lib=. cme check dpkg
...
Warning in 'control source Build-Depends:0' value 'debhelper (>=
11~)': should be (>= 11) not (>= 11~) because compat is 11
Warning in 'control source Build-Depends:1' value 'python3 (>= 3.2)':
unnecessary greater-than versioned dependency: python3 (>= 3.2).
Debian has oldoldstable -> 3.2.3-6; oldstable -> 3.4.2-2;
oldstable-kfreebsd -> 3.4.2-2; stable -> 3.5.3-1; unstable -> 3.6.3-2;
testing -> 3.6.4-1; unstable -> 3.6.4-1;
Warning in 'control binary:mwic Depends:0' value 'python3 (>= 3.2)':
unnecessary greater-than versioned dependency: python3 (>= 3.2).
Debian has oldoldstable -> 3.2.3-6; oldstable -> 3.4.2-2;
oldstable-kfreebsd -> 3.4.2-2; stable -> 3.5.3-1; unstable -> 3.6.3-2;
testing -> 3.6.4-1; unstable -> 3.6.4-1;
$ doc8
Scanning...
Validating...
.../mwic-0.7.4/doc/manpage.rst:19: D001 Line too long
.../mwic-0.7.4/doc/manpage.rst:20: D001 Line too long
.../mwic-0.7.4/doc/manpage.rst:53: D001 Line too long
# You may want to file a bug on license-reconcile
# about these false positives re Expat vs MIT/X11
$ env PERL5OPT=-m-lib=. license-reconcile
...
License mismatch: File private/check-rst has license MIT/X11 (BSD
like) which does not match Expat. at
/usr/share/perl5/Debian/LicenseReconcile/App.pm line 222, <GEN0> line
3.
<lots more>
# This command checks style. While a consistent style
# is a good idea, people who have different style
# preferences will want to ignore some of the output.
# Do not bother adding non-upstreamable patches for this.
$ find . -type f -iname '*.py' -exec pycodestyle --ignore W191 {} +
<lots>
# This command checks style. While a consistent style
# is a good idea, people who have different style
# preferences will want to ignore some of the output.
# Do not bother adding non-upstreamable patches for this.
$ pydocstyle .
<lots>
$ find . -type f -iname '*.py' -exec pylint3 --rcfile=/dev/null
--msg-template='{path}:{line}:{column}: [{category}:{symbol}] {obj}:
{msg}' --reports=n {} +
<lots>
$ python3-bandit -r .
<lots>
$ grep -nHriE 'fixme|todo|hack|xxx+|broken' .
./tests/multiword-t-he.txt:6:# FIXME:
./tests/test_extdict.py:121: t({'aasumes'}, {'assumes'}) # FIXME? 'assumes'
./tests/test_extdict.py:122: t({'Addtional'}, {'Additional'}) #
FIXME? 'addtional'
./tests/multiword-t-he.exp:17:FIXME:
./tests/multiword-t-he.exp:18:| # FIXME:
./private/run-pylint:32:log=$(mktemp -t pylint.XXXXXX)
./.pylintrc:5: fixme,
$ vulture .
lib/cli.py:54: Unused variable 'namespace'
lib/cli.py:54: Unused variable 'option_string'
lib/cli.py:187: Unused variable 'ch'
lib/cli.py:192: Unused variable 'ch'
lib/cli.py:310: Unused variable 'args'
lib/colors.py:32: Unused variable 'warn'
lib/colors.py:35: Unused variable 'unreverse'
tests/test_blackbox.py:35: Unused attribute 'maxDiff'
tests/test_blackbox.py:85: Unused attribute 'redundant'
tests/test_blackbox.py:90: Unused variable 'enabled'
tests/test_blackbox.py:101: Unused function 'loadTestsFromFile'
tests/test_blackbox.py:105: Unused function 'wantFunction'
tests/test_blackbox.py:115: Unused function '_test'
--
bye,
pabs
https://wiki.debian.org/PaulWise
Reply to: