[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: python-keyring 1.4-1



On 2013-06-18 18:21:27, Dmitry Shachnev wrote:
> >> > What's the status of all the other tests? Many tests are skipped because
> >> > of missing dependencies.
> >>
> >> Gnome-keyring-daemon refuses to run in xvfb. As I do not know other
> >> Secret Service implementations, it's currently impossible to test
> >> GNOME and Secret Service backends (libsecret's upstream testsuite has
> >> some code for mocking Secret Service, but I didn't yet have time to
> >> test it).
> >
> > If we can't run them reliably I'd rather see them disabled.
> 
> These tests either succeed or are skipped — i.e. do not affect the
> build. Why should we disable them?

Because they cause the package to FTBFS if python-secretstorage is
installed and there's no gnome-keyring or dbus session available.

> >> Python-fs is too old in Debian (python-keyring needs at least 0.4), so
> >> this test can't be run also.
> >
> > What about the gdata tests?
> 
> Gdata is a Google backend, so these tests do nothing when you don't
> have an internet connection. Also (with my python-gdata maintainer hat
> on), I would avoid adding any new (build-)dependencies on it because
> it's mostly dead and unmaintained code.

Fine with me then.

Regards
-- 
Sebastian Ramacher

Attachment: signature.asc
Description: Digital signature


Reply to: