On 2013-06-14 14:55:58, Dmitry Shachnev wrote: > Thanks for your review. > > On Wed, Jun 12, 2013 at 2:34 AM, Sebastian Ramacher > <sramacher@debian.org> wrote: > > I'd put the script in /usr/share/doc/python-keyring or > > /usr/share/python-keyring. There's no need to put it in /usr/bin. > > It's now in /usr/share/python-keyring. I think lines 48 and 49 can be removed too. > > Also, I wouldn't copy the the master password from the old keyring to the > > new one. If the user already created a new Crypto keyring with a different > > password, this would destroy it. I'd also make it more explicit when asking > > for the password that it's the password for the old keyring. > > Fixed. > > >> Note that it fails to build when python3-secretstorage is installed > >> (see upstream #102), but there is no problem when you are building in > >> chroot. > > > > So either > > - get ImportKiller fixed, > > - disable ImportKiller based tests for Python 3.3 for now or > > - add python3-secretstorage and python3-gi to Build-Conflicts. > > ImportKiller is fixed now. > > > What's the status of all the other tests? Many tests are skipped because > > of missing dependencies. > > Gnome-keyring-daemon refuses to run in xvfb. As I do not know other > Secret Service implementations, it's currently impossible to test > GNOME and Secret Service backends (libsecret's upstream testsuite has > some code for mocking Secret Service, but I didn't yet have time to > test it). If we can't run them reliably I'd rather see them disabled. > Python-fs is too old in Debian (python-keyring needs at least 0.4), so > this test can't be run also. What about the gdata tests? It currently FTBFS twice in a row: | dpkg-source: info: local changes detected, the modified files are: | python-keyring-1.4/keyring.egg-info/PKG-INFO | python-keyring-1.4/keyring.egg-info/SOURCES.txt | python-keyring-1.4/keyring.egg-info/dependency_links.txt | python-keyring-1.4/keyring.egg-info/entry_points.txt | python-keyring-1.4/keyring.egg-info/requires.txt | python-keyring-1.4/keyring.egg-info/top_level.txt Regards -- Sebastian Ramacher
Attachment:
signature.asc
Description: Digital signature