[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Python fdb



* Philippe Makowski <pmakowski@espelida.com>, 2012-12-25, 19:29:
https://mentors.debian.net/package/python-fdb

Link to .dsc for the lazy:
http://mentors.debian.net/debian/pool/main/p/python-fdb/python-fdb_0.9.9-1.dsc

Unfortunately, the package FTBFS here:
|    debian/rules override_dh_auto_clean
| make[1]: Entering directory `/build/python-fdb-ay3PAK/python-fdb-0.9.9'
| dh_auto_clean
| Traceback (most recent call last):
|   File "setup.py", line 6, in <module>
|     from setuptools import setup, find_packages
| ImportError: No module named setuptools
| dh_auto_clean: python2.6 setup.py clean -a returned exit code 1
| make[1]: *** [override_dh_auto_clean] Error 1


I also noticed that docs/_static/ contains some minified JavaScript files without source. You'll have to either ask upstream to include un-minified version of these, or remove from .orig.tar.


debian/copyright says the license is BSD-3-clauses, but in fact LICENSE.txt contains a different license.


I have some warnings

Indeed, Lintian emits quite a few tags. Here are some hints how to fix them:

I: python-fdb: description-synopsis-might-not-be-phrased-properly
I: python3-fdb: description-synopsis-might-not-be-phrased-properly

The package synopsis (aka short description) should be a noun phrase, not a
full sentence. See Developer's Reference §6.2.2 for details.

I: python-fdb source: duplicate-long-description python-fdb python-fdb-doc python3-fdb
I: python-fdb source: duplicate-short-description python-fdb python3-fdb

These should be easy to fix: each package should have different description.

W: python-fdb source: out-of-date-standards-version 3.9.3 (current is 3.9.4)

Fixing this one should be obvious.

W: python-fdb-doc: new-package-should-close-itp-bug
W: python-fdb: new-package-should-close-itp-bug
W: python3-fdb: new-package-should-close-itp-bug

See Developer's Reference §5.1 and §5.8.4.

W: python-fdb: extra-license-file usr/share/doc/python-fdb/LICENSE.TXT

Once the copyright file is fixed, LICENSE.TXT won't be needed in the binary package, so just don't include in in debian/docs.

W: python-fdb-doc: embedded-javascript-library usr/share/doc/python-fdb-doc/docs/_static/jquery.js
W: python-fdb-doc: embedded-javascript-library usr/share/doc/python-fdb-doc/docs/_static/underscore.js

You might want to use dh_sphinxdoc to fix these.


Additionally, lintian4python emits (among others):

e: python-fdb: pyflakes-undefined-name usr/share/pyshared/fdb/fbcore.py:245: Timestamp
e: python-fdb: pyflakes-undefined-name usr/share/pyshared/fdb/fbcore.py:4398: _string2reqbuf
e: python-fdb: pyflakes-undefined-name usr/share/pyshared/fdb/fbcore.py:4400: _numeric2reqbuf
e: python-fdb: pyflakes-undefined-name usr/share/pyshared/fdb/services.py:275: ProgrammingError
w: python-fdb-doc: rst-source-referenced-by-searchindex.js-does-not-exist usr/share/doc/python-fdb-doc/docs/_sources/index.txt (usr/share/doc/python-fdb-doc/docs/searchindex.js)
w: python-fdb-doc: rst-source-referenced-by-searchindex.js-does-not-exist usr/share/doc/python-fdb-doc/docs/_sources/getting-started.txt (usr/share/doc/python-fdb-doc/docs/searchindex.js)
w: python-fdb-doc: rst-source-referenced-by-searchindex.js-does-not-exist usr/share/doc/python-fdb-doc/docs/_sources/reference.txt (usr/share/doc/python-fdb-doc/docs/searchindex.js)
w: python-fdb-doc: rst-source-referenced-by-searchindex.js-does-not-exist usr/share/doc/python-fdb-doc/docs/_sources/license.txt (usr/share/doc/python-fdb-doc/docs/searchindex.js)
w: python-fdb-doc: rst-source-referenced-by-searchindex.js-does-not-exist usr/share/doc/python-fdb-doc/docs/_sources/changelog.txt (usr/share/doc/python-fdb-doc/docs/searchindex.js)
w: python-fdb-doc: rst-source-referenced-by-searchindex.js-does-not-exist usr/share/doc/python-fdb-doc/docs/_sources/usage-guide.txt (usr/share/doc/python-fdb-doc/docs/searchindex.js)
w: python-fdb-doc: rst-source-referenced-by-searchindex.js-does-not-exist usr/share/doc/python-fdb-doc/docs/_sources/python-db-api-compliance.txt (usr/share/doc/python-fdb-doc/docs/searchindex.js)
w: python-fdb-doc: rst-source-referenced-by-searchindex.js-does-not-exist usr/share/doc/python-fdb-doc/docs/_sources/differecnes-from-kdb.txt (usr/share/doc/python-fdb-doc/docs/searchindex.js)

--
Jakub Wilk


Reply to: