Re: RFS: python-unicodecsv (Closes: #669678)
Lintian now emits:
W: python-unicodecsv source: debhelper-overrides-need-versioned-build-depends (>= 7.0.50~)
I: python-unicodecsv source: quilt-patch-missing-description 01disable_float_double_tests.diff
* Thomas Bechtold <thomasbechtold@jpberlin.de>, 2012-04-23, 18:32:
Please run tests at build time.
fixed in debian/rules
It should be override_dh_auto_test, not overwrite_dh_auto_test. Please
honour DEB_BUILD_OPTIONS=nocheck.
fixed both on mentors.debian.net .
seems that the tests never run. fixed this as well and disabled 2 tests
(see debian/patches) because the tests failed.
How about fixing the tests rather than disabling them? :) See the
attached patch.
Please test against all supported Python versions, not only the
default one.
at build time? how to do this? what are the build dependencies in
debian/control
python-all
and what should i do in debian/rules ? do you have an example package maybe?
Use "pyversions -r" to get list of supported Python versions, then
iterate over them. TIMTOWTDI:
1) abuse %-rules, see e.g. flufl.enum;
2) use a for loop, see e.g. sphinxcontrib-speeling;
3) (my favourite:) use xargs, see e.g. python-byteplay.
--
Jakub Wilk
Description: accommodate the tests with Python >= 2.7 floating point output
Author: Jakub Wilk <jwilk@debian.org>
Forwarded: no
Last-Update: 2012-04-23
--- a/unicodecsv/test.py
+++ b/unicodecsv/test.py
@@ -3,6 +3,7 @@
# csv package unit tests
import os
+import sys
import unittest2 as unittest
from StringIO import StringIO
import tempfile
@@ -766,7 +767,10 @@
try:
writer = csv.writer(fileobj, dialect="excel")
writer.writerow(a)
- expected = ",".join([str(i) for i in a])+"\r\n"
+ float_repr = str
+ if sys.version_info >= (2, 7):
+ float_repr = repr
+ expected = ",".join([float_repr(i) for i in a])+"\r\n"
fileobj.seek(0)
self.assertEqual(fileobj.read(), expected)
finally:
@@ -782,7 +786,10 @@
try:
writer = csv.writer(fileobj, dialect="excel")
writer.writerow(a)
- expected = ",".join([str(i) for i in a])+"\r\n"
+ float_repr = str
+ if sys.version_info >= (2, 7):
+ float_repr = repr
+ expected = ",".join([float_repr(i) for i in a])+"\r\n"
fileobj.seek(0)
self.assertEqual(fileobj.read(), expected)
finally:
Reply to: