Kumar Appaiah (akumar@ee.iitm.ac.in):
> Piotr Ozarowski <ozarow <at> gmail.com> writes:
> > * You've missed binary-arch rule in debian/rules (see lintian info)
>
> I don't think it's necessary for Arch-Indep packages, lintian doesn't complain
> on my system.
$ lintian --version
Lintian v1.23.22
$ lintian ../harvestman_1.4.6-3.dsc
E: harvestman source: debian-rules-missing-required-target binary-arch
build-arch is not optional, but since it's not needed in your package,
just add an empty rule.
> > * why are you using `find -name file | chmod 755` (and similar)?
> > Isn't `chmod 755 file` not good enough?
>
> Well, since I don't know whether there are subdirectories with more files. Bad,
> but doesn't hurt, does it? :-)
These lines are not needed:
find ./doc |xargs chmod 644
find -name 'config.xml' | xargs chmod 644
dh_fixperms will do the job
Line ("install-$(PYTHON)" rule)
find debian/harvestman -name '*.py[co]' -exec rm -f {} \;
is also not needed, python-central will remove *.py[co] files automatically
(please don't remove the one from clean rule)
> > * no need to use sed in order to change hashbang, pycentral will take
> > care of it
>
> Done.
I don't know why, but dh_python didn't set hashbangs correctly (it's not
changing them at all). I will try to investigate it later, for now please use
sed again, sorry.
> Hope things are better now. See http://kumar.travisbsd.org/debpackages
* please update DH_COMPAT var. in debian/rules (you still have "4" there):
(I recommend using debian/compat file instead, you will not have to export
DH_COMPAT=5 in order to run dh_* manually without warnings/errors)
* remove debian/harvestman.links file and use dh_link in debian/rules
(you have hardcoded "python2.4" there)
* dh_installchangelogs, dh_installdocs and dh_installexamples are called twice, see
install-$(PYTHON) and binary-indep rules
BTW: it would be easier (at least for me ;-P) if you could provide direct link
to .dsc file in your mails (I use dget to download all necessary files)
--
-=[ Piotr Ozarowski ]=-
-=[ http://www.ozarowski.pl ]=-
Attachment:
pgpJXrwX23TyM.pgp
Description: PGP signature