Re: RFS: harvestman web crawler - needs updation!
Piotr Ozarowski <ozarow <at> gmail.com> writes:
> * Standards-Version is outdated (check upgrading-checklist.txt file)
Changed.
> * debian/pycompat file is missing (`echo "2" > debian/pycompat`)
Done.
> * debhelper should be moved to Build-Depends
Done.
> * You've missed binary-arch rule in debian/rules (see lintian info)
I don't think it's necessary for Arch-Indep packages, lintian doesn't complain
on my system.
> * "current, >=2.4" will not work with current dh_python so putting
> "2.4" in XS-Python-Version header is correct but why do you have
> hardcoded python2.4 in debian/rules? Please use something like
> PYTHON=$(shell pyversions -r)
> and compile with $(PYTHON) instead of python2.4
Done.
> * remove "Replaces: harvestman (<= 1.4.6-2)" line in control file,
> it's the same package, right?
Done.
> * why are you using `find -name file | chmod 755` (and similar)?
> Isn't `chmod 755 file` not good enough?
Well, since I don't know whether there are subdirectories with more files. Bad,
but doesn't hurt, does it? :-)
> * no need to use sed in order to change hashbang, pycentral will take
> care of it
Done.
> * IMHO putting docs list in debian/docs file instead of calling
> dh_installdocs 4x is better idea (BTW: you can do it in one line)
I have called it once.
Hope things are better now. See http://kumar.travisbsd.org/debpackages
Thanks.
Kumar
Reply to: