[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Gimp-print-devel] Debian packaging of gutenprint



   From: "Roger Leigh" <rleigh@codelibre.net>
   Date: Fri, 31 Oct 2008 00:41:46 +0000

   On Thu, Oct 30, 2008 at 07:44:33PM -0400, Robert Krawitz wrote:
   >    From: "Roger Leigh" <rleigh@codelibre.net>
   >    Date: Thu, 30 Oct 2008 22:48:43 +0000

   > If you (or any other distribution) wants to do this, I'd suggest using
   > EXTRA_VERSION of "-debian_1" or the like so that we know that it's a
   > version with non-standard changes.  Also, make sure you have someone
   > subscribed to the list, and preferably with a Sourceforge account that
   > we can assign bugs to (if someone's using a non-standard release, I
   > would redirect all bugs against that release to the distribution
   > maintainer for initial triage).

   For Debian at least, we would most likely only ever pull in
   specific changesets from upstream in order to fix a particular bug,
   that is we would never introduce code not already committed into
   upstream CVS.

The problem with that is that you'll still wind up with a different
source base than the particular upstream named release.  My preference
would be for you to pull the entire new release, or if that's not
practical to otherwise identify the release as being unofficial.

   Currently, the exception is a single one-line difference we patch in:
   http://git.debian.org/?p=3Dcollab-maint/gutenprint.git;a=3Dblob;f=3Ddebian/=
   patches/20_fix_gimpprint_menu_entry.dpatch;h=3D26df711e4efa8d67ece6bc21633d=
   e57ca11ce2fc;hb=3D4bca2a19e7f4486d250a72e495caa99fb993fc85

   diff -urNad gutenprint-5.0.0~/src/gimp2/print-print.c gutenprint-5.0.0/src/=
   gimp2/print-print.c
   --- gutenprint-5.0.0~/src/gimp2/print-print.c   2006-07-04 04:57:59.0000000=
   00 +0200
   +++ gutenprint-5.0.0/src/gimp2/print-print.c    2006-09-13 10:36:32.0000000=
   00 +0200
   @@ -43,7 +43,7 @@
			     (BAD_CONST_CHAR) copy,
			     (BAD_CONST_CHAR) VERSION " - " RELEASE_DATE,
			     /* Do not translate the prefix "<Image>" */
   -                         (BAD_CONST_CHAR) N_("<Image>/File/Print..."),
   +                         (BAD_CONST_CHAR) N_("<Image>/File/Send/Print..."),
			     (BAD_CONST_CHAR) types,
			     GIMP_PLUGIN,
			     n_args, 0,

   This was written by Till, and I think it's been proposed on the
   list for inclusion quite some time back.  If it got lost, it would
   be great if you could include this.  This puts the menu entry in
   the correct location on the File menu.  IIRC, this would have
   broken GIMP 2.0/2.2, but is needed on 2.4/2.6.  It's probably OK to
   commit now 2.2 is long obsolete.

I don't think that this should be applied, for two reasons:

1) GIMP 2.4/2.6 will use print-gutenprint.c unless you explicitly pass
   --without-gimp2-as-gutenprint on the command line, which is not
   standard.  print-print.c is specifically intended for use with GIMP
   2.0/2.2.  Normally with GIMP 2.4+ the option is named Print with
   Gutenprint...

2) The built-in GNOME-Print based plugin in GIMP appears to be
   File/Print, not File/Send/Print.  Unless the GIMP folks disagree, I
   think we should use the same layout.

-- 
Robert Krawitz                                     <rlk@alum.mit.edu>

Tall Clubs International  --  http://www.tall.org/ or 1-888-IM-TALL-2
Member of the League for Programming Freedom -- mail lpf@uunet.uu.net
Project lead for Gutenprint   --    http://gimp-print.sourceforge.net

"Linux doesn't dictate how I work, I dictate how Linux works."
--Eric Crampton


Reply to: