[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Tool for blessing HFS+ filesystems required



On 2/3/21 12:16 PM, Linux User #330250 wrote:
> BUT, one "bug" of this has always been, even with an older version of
> the Apple diskdev_cmds, that the option "-h hfs" was always needed.
> Therefor, those two command do the same to create an HFS+ volume:
> * mkfs.hfsplus /dev/sdxn
> * mkfs.hfs /dev/sdxn
> And these always create a "legacy" HFS volume:
> * mkfs.hfs -h hfs /dev/sdxn
> * mkfs.hfsplus -h hfs /dev/sdxn
> 
> In other words, the symlink mkfs.hfs doesn't make it create a HFS
> volume, and the symlink mkfs.hfsplus  doesn't make it create a HFS+
> volume, it solely depends on the "-h hfs" commandline option, or not.

This bug itself is actually trivial to fix once HFS Legacy support has
been added back in.

You just need to replace the line in [1] with:

if (strmp(progname, "mkfs.hfs") == 0)
	forceHFS = TRUE;
else
	forceHFS = FALSE;

Adrian

> [1] https://sources.debian.org/src/hfsprogs/332.25-11/newfs_hfs.tproj/newfs_hfs.c/#L179

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913


Reply to: