Re: Bug#948120: libreoffice: Incorrect conditional test to enable BUILD_NOGUI_PACKAGES
Hi,
On Sat, Jan 04, 2020 at 02:07:36PM +0100, John Paul Adrian Glaubitz wrote:
> On 1/4/20 10:19 AM, John Paul Adrian Glaubitz wrote:
> > I haven't verified it, but my suspicion is that the following conditional test is
> > incorrect as the function findstring will match "ppc64" in OOO_NOGUI_ARCHS if
> > it contains "ppc64el":
> >
> > ifeq "$(ENABLE_GUI)" "y"
> > ifneq (,$(findstring $(DEB_HOST_ARCH),$(OOO_NOGUI_ARCHS)))
> > BUILD_NOGUI_PACKAGES=y
> > endif
> > else
> I can confirm that replacing "findstring" with "filter" here fixes the build
> on ppc64.
That just means that BUILD_NOGUI_PACKAGES=n is set and the nogui part is not even tried.
ppc64 is fast and has server uses, so should definitel get -nogui.
I am not mistaken:
No, this is just a workaround. The real fix would imho be to find out
why .desktop is not present when it's tried to be removed..
Regards,
Rene
Reply to: