[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#948120: libreoffice: Incorrect conditional test to enable BUILD_NOGUI_PACKAGES



On 1/4/20 10:19 AM, John Paul Adrian Glaubitz wrote:
> I haven't verified it, but my suspicion is that the following conditional test is
> incorrect as the function findstring will match "ppc64" in OOO_NOGUI_ARCHS if
> it contains "ppc64el":
> 
> ifeq "$(ENABLE_GUI)" "y"
>   ifneq (,$(findstring $(DEB_HOST_ARCH),$(OOO_NOGUI_ARCHS)))
>     BUILD_NOGUI_PACKAGES=y
>   endif
> else
I can confirm that replacing "findstring" with "filter" here fixes the build
on ppc64.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913


Reply to: