Re: Bug#948120: libreoffice: Incorrect conditional test to enable BUILD_NOGUI_PACKAGES
On 1/4/20 2:28 PM, Rene Engelhard wrote:
> That just means that BUILD_NOGUI_PACKAGES=n is set and the nogui part is not even tried.
> ppc64 is fast and has server uses, so should definitel get -nogui.
That might be the case. But ppc64 is currently *not* in the list
of OOO_NOGUI_ARCH. Yet your rules file was executing parts of
the code as if it was in OOO_NOGUI_ARCH.
> I am not mistaken:
>
> No, this is just a workaround. The real fix would imho be to find out
> why .desktop is not present when it's tried to be removed..
What? I'm not sure why this would be a workaround. You didn't
put ppc64 in the list of NOGUI architectures. That means the
nogui code itself wasn't build.
>From [1]:
"Searches in for an occurrence of find. If it occurs, the value is find;
otherwise, the value is empty. You can use this function in a conditional to
test for the presence of a specific **substring** in a given string. "
Emphasis mine.
You want to use "filter" when looking for architectures, not "findstring"
which will match "ppc64" in "ppc64el".
Adrian
> [1] https://www.gnu.org/software/make/manual/html_node/Text-Functions.html
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@debian.org
`. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Reply to: