[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: baffled .. the 2019-01-27 debian-10.0-ppc64-NETINST-1.iso not bootable



On 4/6/19 23:34, John Paul Adrian Glaubitz wrote:
On 4/6/19 11:22 PM, John Paul Adrian Glaubitz wrote:
But that file ([1]) is 5 years old, so maybe the way the shell -
actually `busybox` - handles (or ignored) a "local" keyword outside of a
function has changed?

The installer team just uploaded busybox 1.30 last month [1] which introduced
at least one serious bug [2]. Might be that busybox 1.30 broke more stuff.

shellcheck complains about that "local" as well but it claims it's not known
to the original Unix shell at all:

glaubitz@epyc:..glaubitz/tmp> shellcheck 26zfs-devices

In 26zfs-devices line 3:
. /usr/share/debconf/confmodule
^-- SC1091: Not following: /usr/share/debconf/confmodule was not specified as input (see shellcheck -x).


In 26zfs-devices line 8:
if [ ! -f /var/lib/partman/zfs ] && [ "$(udpkg --print-os)" = kfreebsd -o "$(udpkg --print-os)" = linux ] ; then
                                                                        ^-- SC2166: Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.


In 26zfs-devices line 19:
         local zfs_load_timeout
         ^-- SC2039: In POSIX sh, 'local' is undefined.

Could as well be. But if the used sh gets that strict sometime in the
future, a lot of changes in the shell scripts used by d-i will be
necessary I'm afraid.



In 26zfs-devices line 23:
             let zfs_load_timeout++
             ^-- SC2039: In POSIX sh, 'let' is undefined.
                                 ^-- SC2039: In POSIX sh, ++ is undefined.

Dito. And here "checkbashisms" also complains:
```
partman-zfs/init.d$ checkbashisms zfs-devices

possible bashism in zfs-devices line 18 (let ...):
            let zfs_load_timeout++
```


glaubitz@epyc:..glaubitz/tmp>

I guess someone needs to build a fresh debian-installer on amd64, build a fresh
CD image with debian-cd and test whether this issue shows there as well.

From David Vantyghem's email it looks like it doesn't happen for the
powerpc version of the ISO.

****

After removing the "local" keyword I went through most of the
installation but failed during the grub installation step:

```
main-menu[4860]: (process:6375): /usr/bin/grub-installer: line 252:
/usr/lib/grub-installer/mkhfs-bootstrap.sh: not found
```

That's because I forgot to adapt "debian/grub-installer.install" to also
install the new "mkhfs-bootstrap.sh" script. :-/

Sorry, my bad. I didn't anticipate this. I'll force push a change to fix
that asap. Though this won't help for the created powerpc/ppc64 ISOs.
GRUB installations won't work with them unless someone inserts [1] into
the installer environment as `/usr/lib/grub-installer/mkhfs-bootstrap.sh`.

Cheers,
Frank

[1]:
https://salsa.debian.org/frank-scheiner-guest/grub-installer/raw/support-grub-installs-on-newworld-powermacs-with-hfs-bootstrap/mkhfs-bootstrap.sh


Reply to: