[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: New discussion: ppc64 installer -- ext2 /boot partition to keep yaboot happy.

On 11/02/2017 01:53 PM, John Paul Adrian Glaubitz wrote:
Sorry, you lost me here. What should I resend, the patches were included as compressed
attachments. Should I resend them inline?

My problem is that you send a wall of text, with all the patches mangled in that
I have to start fishing for the changes now.

The normal standard is to send patches using "git send-email" which will automatically format the patches for a proper review. It's also more common to send smaller patches
as they are easier to review.

Ok, I see. I will have a look how this works.

If I use your big patch "make-d-i-grub-installer-work-for-newworld-power-macs.diff" patch now and just apply it as-is, I am risking of breaking grub-installer on other architectures and you can probably imagine how the other debian-installer maintainers
will react to such a change.

I think I understand. :-)

You don't have to make mini patches, but the changes should be separate from each
other logically so that we minimize the risk of breaking something.

Ok, I will try to separate this in smaller chunks. E.g. I could make a patch which adds the functions only - just adding them without name collisions should not break anything. The parts in the main execution path can be added with another patch. I don't think that these can be separated, if it is required that the script should work after each new patch. Or is it sufficient if it works after applying the whole patch set?

Thanks for taking the time to describe the issue with my earlier message.


Reply to: