[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: changing mac address of Sun GEM



At Sat, 24 Mar 2007 08:54:41 +1100, Benjamin Herrenschmidt wrote:
> 
> netif_running() means the device is open() (which generally means the
> interface is up).

Ok.  That's what I thought.  I use "ifplugd" and I thought that the
interface was down as long as no cable is connected, but it seems the
interface is up as soon as "ifplugd" is running.

> You need to be a bit careful here. The chip might be off (power
> managed).
> 
> I would suggest you do something a bit like change_mtu there, though you
> don't actually need to take the locks, only the mutex, and please do
> test gp->running before touching the hardware (with the lock held).

Ok, I changed it.  It should be safe now?

Thanks,
Ruben

Attachment: patch-sungem.c
Description: Binary data


Reply to: