Re: [PATCH] ppc32: Rework power management take #3

[Stelian Pop <stelian@popies.net>]

> Ok, the patch is now getting "good enough" for wider testing. It applies
> on current "git" tree (or 2.6.12-rc6 when/if that is ever released). It
> requires one other patch to be applied first:
> 
> http://gate.crashing.org/~benh/ppc32-remove-macserial.diff
> 
> The PM patch itself can be found at:
> 
> http://gate.crashing.org/~benh/ppc32-rework-pm.diff
> 
> This patch completely reworks both suspend-to-ram and suspend-to-disk
> support on PowerMac:

This patch works almost perfectly on my PowerBook5,6 15" (ATI). Suspending to RAM
and DISK work beautifully, even in X, even with a USB mouse connected, even with
some music being played.

I have a few minor glitches with suspend-to-disk only:

  * after resuming the sound won't work until you 'touch' the master volume and/or
    the DRC level in alsamixer.

  * looking at the console messages when resuming, I see those 'normal' messages:
	Stopping tasks: =============================================================================================================================================|
	Freeing memory... done (42488 pages freed)
	swsusp critical section done
    After those messages and before the machine powers down, I see a few messages
    related to resume, such as (hand copied so not necessarily exact):
	Restoring Highmem
	radeonfb resuming from state 2
	eth0: resuming
	PHY ID: 1410cc2, addr: 0
	hda: Enabling Ultra DMA 5
	hdc: Enabling MultiWord DMA 2
	ehci_hcd 0001:10:1b.2: park 0
	ehci_hcd 0001:10:1b.2: USB 2.0 restarted
    I'm not sure those actions are supposed to happen. Or is this necessary for 
    powering down the machine ?

  * time doesn't get restored correctly, I have to do a
	/etc/init.d/hwclock.sh start
    after resuming. I'm not sure this is normal or should be done automagically
    on resume.
 
Thanks Ben !

Stelian.
-- 
Stelian Pop <stelian@popies.net>