[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: incompatible unaligned.h between x86 and ppc - kernel-hackers verify please

On Wed, Nov 03, 2004 at 08:17:56AM -0500, Albert Cahalan wrote:
> If __ARMEB__ is not compiler-defined, something is
> broken.

I didn't know __ARMEB__ was set by compiler, I though it was kernel
configuration stuff. anyway, that make the problem on ppc then.
> Next time, start with i386. If Linus won't go for it,
> then don't screw around adding __KERNEL__ to other places.
> Stuff breaks, needlessly. I'd go so far as to say that
> the Linux API has been broken on ppc.

you could use even harder words; that's probably the end of world ... :)

Anyway, Benjamin a trivial patch follow, can you apply it ? 
(2.6.9 and 2.6.10 seems equally bitten by that)
Unless there's something we don't know about the __KERNEL__ protection.


--- unaligned.h.orig	2004-11-03 18:37:24 +0100
+++ unaligned.h	2004-11-03 18:37:29 +0100
@@ -1,4 +1,3 @@
-#ifdef __KERNEL__
 #ifndef __PPC_UNALIGNED_H
 #define __PPC_UNALIGNED_H
@@ -15,4 +14,3 @@
 #define put_unaligned(val, ptr) ((void)( *(ptr) = (val) ))
-#endif /* __KERNEL__ */

Reply to: