Dear debian-powerpc, you may recall early last year I asked for help getting mirrormagic to compile under powerpc. David Roundy provided a patch (to gadgets.c) which appeared to fix the problem. Holger Schemel, the upstream author, is currently preparing a new upstream revision and wishes to incorporate the Debian patches. However, he is concerned about the fix we used to compile for powerpc, worried that the fix is not platform independent. I think you'll be better qualified to answer to the question, so I've forwarded his question on to you. Keeping the cc: to Holger and myself. (info@artsoft.org) will probably be helpful for us. Thanks! Drew Parsons On Sun, Mar 17, 2002 at 09:32:18PM +0100, Holger Schemel wrote: > Hello Drew, > > > Also, here is a small patch which fixes support for the powerpc architecture > > (va_arg got mixed up in gadgets.c), and sound handling when no > > sound card is present (sound.c). > > > > ======================================================= > > --- mirrormagic-2.0.0.orig/src/libgame/gadgets.c > > +++ mirrormagic-2.0.0/src/libgame/gadgets.c > > @@ -309,7 +309,7 @@ > > break; > > > > case GDI_CHECKED: > > - gi->checked = va_arg(ap, boolean); > > + gi->checked = (boolean) va_arg(ap, int); > > break; > [...] > > Hm, applying this patch would mess up things for other platforms, > because "boolean" is typedef'ed as "unsigned char". If it simply > gets replaced by "int", va_arg reads a 16 or 32 bit value instead > of a 8 bit value. > > Have you tried "(boolean) va_arg(ap, unsigned char)" instead? > Or does the PowerPC architecture generally have problems with > "char" and "va_arg"? Then it might help to typedef "boolean" > to "int" for the PowerPC architecture. (Do you know if/how this > could be determined by preprocessor definitions?) > > Best regards, > Holger -- PGP public key available at http://people.debian.org/~dparsons/drewskey.txt Fingerprint: A110 EAE1 D7D2 8076 5FE0 EC0A B6CE 7041 6412 4E4A
Attachment:
pgpeH8aMCSFEl.pgp
Description: PGP signature