Bug#88111: policy should not dictate implementation details
On Fri, Mar 02, 2001 at 11:48:49AM +0100, Wichert Akkerman wrote:
> Previously Julian Gilbey wrote:
> > Simply not true. Read the source code for dpkg-buildpackage. I'm
> > objecting to this until we specify the following (growing) minimal
> > interface:
> >
> > debian/rules [variable=value ...] target [variable=value ...]
>
> I highly object to complicant the interface to debian/rules. Environment
> variables work fine, and are *much* easier to handle, especially if we
> someday decide to replace debian/rules with something that is not a
> makefile.
Your proposed patch to dpkg-buildpackage will resolve that issue.
> > debian/rules -q target
> >
> > exit: 2 if target cannot be built (doesn't exist), non-2 otherwise
>
> I still completely fail to see why that -q is needed. I can't find
> any argumentation for introducint it.
Patch for dpkg-buildpackage once the build-arch/build-indep proposal
goes into policy:
if [ x$sourceonly = x ]; then
- withecho debian/rules build $archlist
+ if [ "$binaryonly" = -B ]
+ then
+ debian/rules -q build-arch > /dev/null 2>&1
+ if [ $? -eq 2 ]
+ then
+ withecho debian/rules build $archlist
+ else
+ withecho debian/rules build-arch $archlist
+ fi
+ fi
withecho $rootcommand debian/rules $binarytarget $archlist
fi
Julian
--
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Julian Gilbey, Dept of Maths, Queen Mary, Univ. of London
Debian GNU/Linux Developer, see http://people.debian.org/~jdg
Donate free food to the world's hungry: see http://www.thehungersite.com/
Reply to: