[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFC: debhelper changes for perl module packages -- AUTOMATED_TESTING and verbose tests



-=| Jonathan Yu, 10.09.2013 15:39:55 -0400 |=-
> I agree with your proposal and with all the other comments in this 
> thread.

Cool.

> One thing I do want to note:
> 
>  * export AUTOMATED_TESTING=1 when invoking the test system
> 
> It's worth mentioning that we have been doing this for a long time as
> pkg-perl policy anyway, so for our packages there's no real change (except
> that we can stop overriding dh_auto_test to also add the AUTOMATED_TESTING
> environment variable).

I don't think it is mass practice to have this in debian/rules. I've 
grepped through all group's packages and found only 36 debian/rules 
files with AUTOMATED_TESTING in them.

> I think that it's a sensible change, especially given the reference you
> give re: the Lancaster consensus.
> 
> Overriding the variable should be relatively easy, right? Just unset that
> env variable or force it to some value?
> 
> I'd expect something like this to work:
> 
> override_dh_auto_test:
> AUTOMATED_TESTING=0 dh_auto_test

It might, depending on how upstream code checks for this variable, 
e.g. 'skip "not now" if exists $ENV{AUTOMATED_TESTING};' won't work.

In any case tests failing with AUTOMATED_TESTING are buggy anyway 
since they'd fail with CPAN testers too.

Attachment: signature.asc
Description: Digital signature


Reply to: