Re: Bug#719016: eiskaltdcpp-cli: needs adaptation to libjson-rpc-perl 1.03
-=| Boris Pek, 08.08.2013 01:15:01 +0400 |=-
> >> Is it possible to check which version is available and to load module depending
> >> on the result?
> >
> > Alright. Please find attached a patch that would work with either old
> > or new RPC-JSON at the expense of some code bloat.
>
> Hmm, I have just pushed very similar patch:
> https://github.com/eiskaltdcpp/eiskaltdcpp/commit/767538d
>
> I do not know perl at all. So could you compare which variant is better
> (your or mine)?
Yours depends on version numbers, mine depends on module existence.
Since the version number is artificial, I'd say that checking for
module availability is better. For example, according to upstream
change log, the incompatible changes are made in CPAN release
versioned '1.00_01', which is an awful thing to compare to.
Reply to: